search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
943 stars 300 forks source link

[MGTP-Left Navigation-Custom Properties]:‘Tuesday, May 2, 2023’ text looks like as heading but not defined in heading tag. #2243

Closed vagpt closed 1 year ago

vagpt commented 1 year ago

Test Environment:  OS Build: Windows 11  Version: 22H2 (OS Build 25300.1000)  Browser: Edge dev  Browser Version 114.0.1807.5 (Official build) dev (64-bit) URL: Components / mgt-agenda / Style - Custom Properties ⋅ Storybook User ID: V-id  Screen reader: Narrator   Repro Steps: 

  1. Open the above URL and login with valid credentials.
  2. Turn on 'Narrator' using 'Ctrl+ win+ enter' keys.
  3. The ‘Microsoft Graph Toolkit Playground' Overview page will be displayed. 
  4. Navigate to the 'Left rail navigation' region using tab key.
  5. Navigate to 'Custom Properties’ control and select it.
  6. The ‘Custom Properties’ page will open.
  7. Navigate to page using 'H' key in scan mode of narrator.
  8. Observe the screen reader announcement.

Actual Results: ‘Tuesday, May 2, 2023’ text looks like as heading but not defined in heading tag. When the user navigates over the page by pressing short cut key 'H' in scan mode of narrator, it is not announcing ‘Tuesday, May 2, 2023’ texts as heading.

Expected Result: Visual headings like ‘Tuesday, May 2, 2023’ should be programmatically defined as headings and it should be accessible with short cut key 'H' as well.

Note:

  1. Same issue is repro throughout the ‘Custom Properties’ page.
  2. Same issue is repro with NVDA screen reader.
  3. Same issue is repro under " ‘Mgt -agenda ->Properties -> Group by day’".

User Experience: Screen reader users would face difficulty knowing the context of the section and face difficulty in navigating if the visual headings don't define as the heading.

WCAG reference link: Understanding Success Criterion 1.3.1 | Understanding WCAG 2.0 (w3.org)

Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)"

https://user-images.githubusercontent.com/95913748/236803103-e61fa48a-a43f-4836-8ef3-11c3e704f000.mp4

WCAG1 3 1-‘Tuesday, May 2, 2023’ text looks like as heading but not defined in heading tag
ghost commented 1 year ago

Hello vagpt, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

gavinbarron commented 1 year ago

It's not a heading per se. we can't make it use an h tag as that forces assumtpions on the users of the library.

@vagpt can we please close this as a false positive?

vagpt commented 1 year ago

As per the above comment closing this issue.