microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
936 stars 296 forks source link

[MGTP- Mgt-tasks - tasks]: Name is not defined for the 'More Option' button present on the added tasks. #2290

Closed vagpt closed 1 year ago

vagpt commented 1 year ago

Test Environment: OS Build: Windows 11 Version: 22H2 (OS Build 25346.1001) Browser: Edge dev Browser Version 115.0.1843.0 (Official build) dev (64-bit) URL: https://mgt.dev/next/v3/?path=/story/components-mgt-tasks--tasks User ID: V-id Screen reader: Narrator

Repro Steps:

  1. Open the above URL and login with valid credentials.
  2. Turn on Narrator using 'Ctrl+ win+ enter' key.
  3. 'Microsoft Graph Toolkit Playground' Overview page will get displayed.
  4. Navigate to the 'Component' and press tab key to navigate to the 'mgt-tasks'.
  5. Press enter key to select 'Tasks'.
  6. Press 'Enter' key and navigate to the added tasks list.
  7. Now press tab key and navigate to 'More Option' button and observe the issue.

Actual Result: Name is not defined for the 'More Option' button. While navigating to it screen reader is announcing as 'Button'.

Expected Result: Name should be defined for the 'More Option' button present under the added tasks and screen reader should convey the information as 'More Option button'. Also, on activating it focus should be landed on the list items present under button.

Note: Same issue is reproduced with NVDA screen reader. This issue is repro for all more options button present under tasks screen.

User impact: In the absence of name for the control, user with screen reader is not able to understand the purpose of the component. Thus, it is difficult for them to decide whether to activate the element or not.

WCAG Reference Link: https://www.w3.org/TR/UNDERSTANDING-WCAG20/ensure-compat-rsv.html

Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)"

https://github.com/microsoftgraph/microsoft-graph-toolkit/assets/95913748/917acae0-60da-4623-a80f-15c20e92d7e4

WCAG4 1 2-Name is not defined for the 'More Option' button present on the added tasks

ghost commented 1 year ago

Hello vagpt, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

vagpt commented 1 year ago

This issue is working fine on the environment below, hence closing this issue.

Test Environment: URL: https://mgt.dev/next/pr/2399/?path=/story/components-mgt-tasks--tasks OS Version: 23H2 (OS Build 25381.1) Browser Version: Version 115.0.1880.3 (Official build) dev (64-bit) Screen Reader: Narrator