search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
945 stars 303 forks source link

[MGTP-Samples-General-Localization-Select a task list-Add a task]: 'Show date picker' button is not visible when 'Dark mode' is enabled #2299

Closed vagpt closed 9 months ago

vagpt commented 1 year ago

Test Environment: OS Build: Windows 11 Version: 22H2 (OS Build 25300.1000) Browser: Edge dev Browser Version 114.0.1807.5 (Official build) dev (64-bit) URL: Components / mgt-agenda / Properties - Preferred Timezone ⋅ Storybook User ID: V-id

Prerequisites: Color mode>>Dark mode

Repro Steps:

  1. Open the above URL and login with valid credentials.
  2. 'Microsoft Graph Toolkit Playground' Overview page will get displayed. 3.Navigate to 'Components' button using tab key and expand it. 4.Navigate to 'Samples' button using tab key and expand it. 5.Navigate to 'General' button using arrow key and expand it. 6.Navigate to 'Assigned to me' button 7.Navigate to 'Localization' link using arrow key and activate it. 8.Navigate to 'Select a task list' combo edit field and select 'Task' item from the list. 9.Navigate to 'Add a task' text field using tab key and type any task name 10.Navigate to 'Show date picker' button using tab key. 11.Turn on Dark mode and observe the issue.

Actual Result: 'Show date picker' button under 'Localization' page is not visible in 'Dark mode'.

Expected Result: 'Show date picker' button should be properly visible in 'Dark mode'.

Note: This issue reproduces all 'Show date picker' buttons throughout application.

Observation:

  1. Alo, keyboard focus indicator is not visible
  2. Same issue reproduces in 'Aquatic/Desert' modes.(Settings>>Accessibility>>Contrast themes)

User Experience: When any 'control' is not visible when 'Aquatic mode' is enabled, it will be difficult for users having low vision to navigate easily to the desired element and access or understand the purpose of control.

"Have feedback to share on Bugs? Please help fill [Trusted Tester Bug Feedback (office.com)](https://nam06.safelinks.protection.outlook.com/?url=https://forms.office.com/pages/responsepage.aspx?id%3Dv4j5cvGGr0GRqy180BHbR5dUqGQgJ9lItv-jqY8F09lURVdYTENIRkY2UzlCR0NKV1E2VUE5OVpDVy4u&data=04%7c01%7cv-apoorva%40microsoft.com%7c551850210d444be9b28308d9691e3dde%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c637656400998658942%7cUnknown%7cTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7c1000&sdata=l6w0SvVcMSvyGnJ6%2B6uSSgd3braF2dZ7/AdBrqqzIR8%3D&reserved=0

Usable- 'Show date picker' button under 'Localization' page is not visible in 'Dark mode'
ghost commented 1 year ago

Hello vagpt, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

gavinbarron commented 1 year ago

This appears to be a re-statement of #2385 and another now resolved issue. @vagpt can you please close this issue?

vagpt commented 9 months ago

Closing this issue as per the comment above, also we have checked it again on latest environment and this issue is not repro.

image