search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
945 stars 303 forks source link

[MGTP-Mgt Get-Refersh]: 'Soft refresh' button is not functional using keyboard and mouse. #2349

Closed Raisul123 closed 9 months ago

Raisul123 commented 1 year ago

Test Environment: OS Build: Windows 11 Version: 22H2 (OS Build 25300.1000) Browser: Edge dev Browser Version 114.0.1807.5 (Official build) dev (64-bit) URL: https://mgt.dev/next/v3/?path=/story/components-mgt-get--refresh User ID: V-id

Pre-requisites: Navigate using keyboard only.

Repro Steps:

  1. Open the above URL and login with valid credentials.
  2. 'Microsoft Graph Toolkit Playground' Overview page will get displayed.
  3. Navigate to 'Mgt-Get' button using tab key and expand it.
  4. Navigate to 'Refresh' button using tab key and activate it.
  5. Navigate to 'Soft Refresh' item using tab key and activate it using enter/spacebar key.
  6. Observe the issue

Actual result: The 'Soft refresh' item is not actionable by pressing the 'Enter/Space' key using keyboard or Mouse.

Expected Result: The 'Soft refresh' item should be actionable by pressing the 'Enter/Space' key using keyboard or Mouse.

Note: Same issue is repro for 'Hard refresh' button.

User Experience: If the button is not operable via Keyboard/Mouse, the user is not able to perform action on that interactive control, hence it is blocking the user from using the functionality to delete cards.

"Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com) “

Attachment:

The 'Soft refresh' item is not actionable by pressing the 'Enter Space' key using keyboard or Mouse

https://github.com/microsoftgraph/microsoft-graph-toolkit/assets/23114460/bc18e7b9-9dd7-42e0-b49f-1956a162c265

ghost commented 1 year ago

Hello Raisul123, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

gavinbarron commented 1 year ago

Add alerts to both buttons to cause a consistent noticeable action, suggest something like

    alert('requesting soft refresh of mgt-get component');
Raisul123 commented 9 months ago

Hi @gavinbarron ,

Issue has been fixed on below test environment. he updated storybook is available here https://github.com/microsoftgraph/microsoft-graph-toolkit/assets/23114460/a670505a-00ad-4f1b-acbd-c0188df6f1cf

hence closing the issue