microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
939 stars 297 forks source link

[BUG] When signing out using `mgt-login`, we're getting a console error #2933

Closed sebastienlevert closed 6 months ago

sebastienlevert commented 8 months ago

Describe the bug When signing out using the Sign Out button from the flyout, we're receiving an error as we're trying to keep the flyout open and render it by using the getActiveAccount on the underlying provider.

@microsoft_mgt-msal2-provider.js?v=86854ef9:14498  Uncaught (in promise) TypeError: Cannot read properties of null (reading 'name')
    at Msal2Provider.getActiveAccount (@microsoft_mgt-msal2-provider.js?v=86854ef9:14498:21)
    at MgtLogin2.<anonymous> (@microsoft_mgt-react.js?v=f007b767:33578:44)
    at Generator.next (<anonymous>)
    at fulfilled (@microsoft_mgt-react.js?v=f007b767:33494:24)

As the interactive session does not complete, it fails to login again.

@microsoft_mgt-msal2-provider.js?v=86854ef9:649  Uncaught (in promise) BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.  For more visit: aka.ms/msaljs/browser-errors.
    at BrowserAuthError2.AuthError2 [as constructor] (@microsoft_mgt-msal2-provider.js?v=86854ef9:649:22)
    at new BrowserAuthError2 (@microsoft_mgt-msal2-provider.js?v=86854ef9:7157:26)
    at BrowserAuthError2.createInteractionInProgressError (@microsoft_mgt-msal2-provider.js?v=86854ef9:7190:14)
    at BrowserCacheManager2.setInteractionInProgress (@microsoft_mgt-msal2-provider.js?v=86854ef9:8489:34)
    at ClientApplication2.preflightInteractiveRequest (@microsoft_mgt-msal2-provider.js?v=86854ef9:13825:29)
    at ClientApplication2.preflightBrowserEnvironmentCheck (@microsoft_mgt-msal2-provider.js?v=86854ef9:13818:14)
    at ClientApplication2.acquireTokenPopup (@microsoft_mgt-msal2-provider.js?v=86854ef9:13405:14)
    at PublicClientApplication2.loginPopup (@microsoft_mgt-msal2-provider.js?v=86854ef9:13961:19)
    at Msal2Provider.<anonymous> (@microsoft_mgt-msal2-provider.js?v=86854ef9:14457:62)
    at Generator.next (<anonymous>)
sebastienlevert commented 7 months ago

This is likely related to #2951.