search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
964 stars 309 forks source link

LocalizationHelper.strings not assignable #2989

Closed SatishKumar-WSP closed 10 months ago

SatishKumar-WSP commented 10 months ago

Describe the bug A clear and concise description of the bug

To Reproduce Steps to reproduce the behavior:

  1. Find attached sample code file
  2. Open in in VS Code
  3. Run npm install to install the dependencies
  4. Open App.tsx and comment lines from 7 to 13 to run the application
  5. To reproduce error uncomment lines from 7 to 13
  6. Save it and run "npm start" command in Terminal to run the code

For quick access find sample code repository to reproduce the issue https://github.com/INSK02788/mgt-components-in-react.git

Expected behavior As per Microsoft learning document it should run without any issue. https://learn.microsoft.com/en-us/graph/toolkit/customize-components/localization

Screenshots Error snapshot below: image

Normal code for mgt people picker component image

Environment (please complete the following information):

Additional context Add any other context about the problem here.

gavinbarron commented 10 months ago

Thank you for the great repro @INSK02788 this is a clear bug in the way we applied the typing to the strings.

We'll have a fix for this pretty soon

SatishKumar-WSP commented 10 months ago

Thanks @gavinbarron for fixing this issue and taking it on priority 👍