search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
926 stars 288 forks source link

[BUG] Slow updates with new "shimmer" effect #3161

Open dougroutledge opened 2 months ago

dougroutledge commented 2 months ago

Describe the bug Apps now have long periods with avatar white circles instead of initials or pictures from cache. At any point when graph errors or throttles the MGT, the user experience should revert to cache instead of shimmer, since it provides 0 usefulness for the end user. Just wait for 30 seconds is not an answer that will retain customers.

gavinbarron commented 2 months ago

Thanks for the feedback @dougroutledge By default, if there is cached data that has not reached its expiry time this is used instead of going over the wire.

I think what you're asking for is to adopt a stale while revalidate type of approach should the cache expiry period have be reached. Is this an accurate assesment of the request here?

dougroutledge commented 2 months ago

Yes exactly. Any control being rendered on screen should load it's cached data, then update from the over the wire data, instead of an empty white place holder.