microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
922 stars 285 forks source link

fix(a11y): set the title and aria-label for the screen sizing buttons #3188

Closed musale closed 1 month ago

musale commented 1 month ago

Closes #3075

PR Type

Description of the changes

Rewrites the title attribute value for the screen sizing buttons Sets the aria-label attribute value to the title value of the sizing buttons

PR checklist

Other information

microsoft-github-policy-service[bot] commented 1 month ago

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

github-actions[bot] commented 1 month ago

📖 The updated storybook is available here

musale commented 1 month ago

@vagpt review this for a11y

github-actions[bot] commented 1 month ago

📖 The updated storybook is available here

github-actions[bot] commented 1 month ago

📖 The updated storybook is available here

vagpt commented 1 month ago

This issue is working fine on the URL below, hence we are good to close issue related to this PR..

URL: https://mgt.dev/next/pr/3188/?path=/docs/overview--docs#storybook-preview-wrapper

Attachment:

https://github.com/microsoftgraph/microsoft-graph-toolkit/assets/95913748/3d15c77a-34ce-46a4-b27f-142b173615f3

Also, @Mnickii @gavinbarron,

Since issue #3075 was marked external to Storybook and we have added external bug id as well in the bug so do we need to remove the external tagging?

github-actions[bot] commented 1 month ago

📖 The updated storybook is available here

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 82% 100% 0
mgt-components.src.components.mgt-person-card 77% 49% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 68% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 84% 100% 0
mgt-element.src.utils 72% 91% 0
Summary 67% (14551 / 21559) 74% (519 / 699) 0