fix: tab behavior on person while closing person-card - Githubissues

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒

https://docs.microsoft.com/graph/toolkit/overview

Other

939 stars 298 forks source link

fix: tab behavior on person while closing person-card #3193

Closed Mnickii closed 3 months ago

Mnickii commented 4 months ago

Closes #3130

PR Type

Bugfix

Description of the changes

PR checklist

[x] Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
[x] All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
[x] Stories have been added and existing stories have been tested
[ ] Added appropriate documentation. Docs PR:
[ ] License header has been added to all new source files (yarn setLicense)
[x] Contains NO breaking changes

Other information

microsoft-github-policy-service[bot] commented 4 months ago

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

[ ] I have verified a documentation PR has been linked and is approved (or not applicable)
[ ] I have ran this PR locally and have tested the fix/feature
[ ] I have verified that stories have been added to storybook (or not applicable)
[ ] I have tested existing stories in storybook to verify no regression has occured
[ ] I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

github-actions[bot] commented 4 months ago

📖 The updated storybook is available here

github-actions[bot] commented 4 months ago

📖 The updated storybook is available here

github-actions[bot] commented 4 months ago

📖 The updated storybook is available here

Mnickii commented 4 months ago

@vagpt this is ready for review

github-actions[bot] commented 4 months ago

📖 The updated storybook is available here

vagpt commented 4 months ago

This issue is still repro on the URL below. Please find the attachment for the reference.

https://github.com/microsoftgraph/microsoft-graph-toolkit/assets/95913748/1d76fee8-2d17-4bb8-8065-86a3a1bc6996

github-actions[bot] commented 4 months ago

📖 The updated storybook is available here

github-actions[bot] commented 3 months ago

📖 The updated storybook is available here

github-actions[bot] commented 3 months ago

📖 The updated storybook is available here

Mnickii commented 3 months ago

@vagpt @Raisul123 this is ready for testing

github-actions[bot] commented 3 months ago

📖 The updated storybook is available here

github-actions[bot] commented 3 months ago

📖 The updated storybook is available here

github-actions[bot] commented 3 months ago

Package	Line Rate	Branch Rate	Complexity	Health
mgt-components.src.components	86%	75%	0	✔
mgt-components.src.components.mgt-contact	68%	83%	0	➖
mgt-components.src.components.mgt-file	62%	100%	0	➖
mgt-components.src.components.mgt-file-list	46%	100%	0	❌
mgt-components.src.components.mgt-file-list.mgt-file-upload	49%	86%	0	❌
mgt-components.src.components.mgt-get	22%	100%	0	❌
mgt-components.src.components.mgt-messages	68%	100%	0	➖
mgt-components.src.components.mgt-organization	47%	100%	0	❌
mgt-components.src.components.mgt-person	82%	100%	0	✔
mgt-components.src.components.mgt-person-card	77%	49%	0	✔
mgt-components.src.components.mgt-picker	80%	100%	0	✔
mgt-components.src.components.mgt-profile	40%	100%	0	❌
mgt-components.src.components.mgt-tasks-base	87%	100%	0	✔
mgt-components.src.components.mgt-theme-toggle	100%	100%	0	✔
mgt-components.src.components.mgt-todo	79%	100%	0	✔
mgt-components.src.components.sub-components.mgt-flyout	78%	53%	0	✔
mgt-components.src.components.sub-components.mgt-spinner	100%	100%	0	✔
mgt-components.src.graph	38%	78%	0	❌
mgt-components.src.styles	92%	80%	0	✔
mgt-components.src.utils	79%	27%	0	✔
mgt-element.dist.es6.components.src.components	72%	73%	0	➖
mgt-element.dist.es6.mock.src.mock	90%	72%	0	✔
mgt-element.dist.es6.providers.src.providers	85%	73%	0	✔
mgt-element.dist.es6.src	91%	80%	0	✔
mgt-element.dist.es6.utils.src.utils	68%	71%	0	➖
mgt-element.src	93%	40%	0	✔
mgt-element.src.components	78%	100%	0	✔
mgt-element.src.mock	81%	56%	0	✔
mgt-element.src.providers	84%	100%	0	✔
mgt-element.src.utils	72%	91%	0	➖
Summary	67% (14570 / 21595)	74% (520 / 702)	0	➖

github-actions[bot] commented 3 months ago

📖 The updated storybook is available here

musale commented 3 months ago

Ping @vagpt and @Raisul123 this is ready for review.

github-actions[bot] commented 3 months ago

📖 The updated storybook is available here

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vagpt commented 3 months ago

This issue is now working fine on the URL below, hence we are good to close the bug related to this PR.

URL: https://mgt.dev/next/pr/3193/?path=/story/components-mgt-person-html--person-vertical

Attachment: https://github.com/microsoftgraph/microsoft-graph-toolkit/assets/95913748/0a4fc90b-bbcb-4378-8a49-6c9a88342626