fix(a11y): correctly narrate tab status in storybook editor

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒

Other

922 stars 285 forks source link

Closed Mnickii closed 2 weeks ago

Mnickii commented 2 weeks ago

Closes #3077

Bugfix

[x] Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
[x] All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
[x] Stories have been added and existing stories have been tested
[ ] Added appropriate documentation. Docs PR:
[ ] License header has been added to all new source files (yarn setLicense)
[x] Contains NO breaking changes

microsoft-github-policy-service[bot] commented 2 weeks ago

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

[ ] I have verified a documentation PR has been linked and is approved (or not applicable)
[ ] I have ran this PR locally and have tested the fix/feature
[ ] I have verified that stories have been added to storybook (or not applicable)
[ ] I have tested existing stories in storybook to verify no regression has occured
[ ] I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

Mnickii commented 2 weeks ago

@gavinbarron, your comments 1 and 2 are resolved in this PR

Mnickii commented 2 weeks ago

Hi @Raisul123 , @vagpt , this is ready for review