fix: check the options scopes are not empty when getting access token - Githubissues

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒

https://docs.microsoft.com/graph/toolkit/overview

Other

953 stars 306 forks source link

fix: check the options scopes are not empty when getting access token #3256

Closed musale closed 3 months ago

musale commented 4 months ago

Closes #3235

PR Type

Bugfix

Description of the changes

Check if the options.scopes are empty and default to the set scopes.

PR checklist

[ ] Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
[ ] All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
[ ] Stories have been added and existing stories have been tested
[ ] Added appropriate documentation. Docs PR:
[ ] License header has been added to all new source files (yarn setLicense)
[ ] Contains NO breaking changes

Other information

sonarcloud[bot] commented 4 months ago

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint