microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
942 stars 300 forks source link

mgt.dev should support theming #345

Closed elisenyang closed 1 month ago

elisenyang commented 4 years ago

Proposal: mgt.dev should support theming

Description

mgt.dev should support theming to provide a coherent experience when samples are embedded into Microsoft Graph docs and Graph Explorer.

Docs and Graph Explorer support 3 themes:

Rationale

Preferred Solution

When the theme of the documentation page or Graph Explorer is changed, the theme of the embedded sample (includes the component + live code editor) should change to the corresponding theme

Additional Context

A simple solution to implement now (until components support theming) is to change the code editor to be "light" theme so that it's obvious we only support one theme for samples

ghost commented 4 years ago

Hello elisenyang, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌