microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
964 stars 309 forks source link

[BUG] mgt-login set userDetails img issue #401

Closed vogtn closed 4 years ago

vogtn commented 4 years ago

Describe the bug The mgt-login component documentation features the ability to set the person-details attribute for customization of name, image and email: https://docs.microsoft.com/en-us/graph/toolkit/components/login

The image (rendered by mgt-person) appears to be overwritten or not shown, by rendering a default color instead. Email and name are working as expected.

To Reproduce Steps to reproduce the behavior:

  1. Utilize the mgt-login component
  2. set userDetails with profileImage set to image
  3. observe default color used instead

Expected behavior The person component within the login component to display button, should use the image specified by property.

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Ref: https://stackoverflow.com/questions/61382360/mgt-login-set-userdetails-not-work-for-email-and-image

ghost commented 4 years ago

Hello vogtn, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

vogtn commented 4 years ago

The documentation was successfully updated to reflect the correct property name, personImage here:

https://github.com/microsoftgraph/microsoft-graph-docs/pull/7920