search

microsoftgraph / msgraph-beta-sdk-java

Microsoft Graph Beta Java SDK
https://docs.microsoft.com/en-us/graph/sdks/use-beta?tabs=Java
MIT License
24 stars 8 forks source link

Missing Organization.tenantType in beta SDK, whereas the API returns it and it's documented in beta doc #499

Closed cnotin closed 5 months ago

cnotin commented 1 year ago

Expected behavior

The organization resource type should have a tenantType attribute, even in the beta SDK, as documented in beta API https://learn.microsoft.com/en-us/graph/api/resources/organization?view=graph-rest-beta. I also confirm that the beta API returns this field.

Actual behavior

The organization resource type doesn't have a tenantType attribute.

Note that it has a partnerTenantType: https://github.com/microsoftgraph/msgraph-beta-sdk-java/blob/03488c80aa4ac32f4e4e4f008d57c3bdd1d8244d/src/main/java/com/microsoft/graph/models/Organization.java#L158-L165 But it doesn't seem to be the same thing (tenantType should be a string "AAD" or "AAD B2C", whereas partnerTenantType is a whole object).

I noticed that this Java SDK in v1.0 has the tenantType: https://github.com/microsoftgraph/msgraph-sdk-java/blob/c6825773ea32c1265427cf7843954356cd491074/src/main/java/com/microsoft/graph/models/Organization.java#L227-L234 It's documented in v1.0 too https://learn.microsoft.com/en-us/graph/api/resources/organization?view=graph-rest-1.0 so it isn't even a change between v1.0 and beta. So it looks like a regression from the v1.0 to beta SDK.

Steps to reproduce the behavior

cnotin commented 1 year ago

Noticed the same in the .NET beta SDK: https://github.com/microsoftgraph/msgraph-beta-sdk-dotnet/issues/609

cnotin commented 1 year ago

Adding proof that this property is indeed returned by the API, both in v1.0 and beta: image image

baywet commented 7 months ago

Thanks for your patience on this one. We'll open an ICM for the dotnet issue, and keep this one open for visibility until this gets resolved.

baywet commented 7 months ago

Note: since this is a metadata issue, it'll still be present in the new major version of the metadata. Update: it seems that I forgot to create the ICM after my last reply, apologies. Here is the link (you won't be able to access it) https://portal.microsofticm.com/imp/v3/incidents/incident/467589599/summary This property is present in v1 metadata but missing in beta https://github.com/microsoftgraph/msgraph-sdk-java/blob/8a4f789535fd79d3d75dc5afde0f91d223bac417/src/main/java/com/microsoft/graph/generated/models/Organization.java#L149 https://github.com/microsoftgraph/msgraph-beta-sdk-java/blob/8a92eeb0d8c99c5c25c3b6430580a4b70a07f0c7/src/main/java/com/microsoft/graph/beta/generated/models/Organization.java#L160

ubertil commented 7 months ago

Thanks for the follow-up @baywet ! When can we expect the property to be available on the /beta endpoint ?

baywet commented 6 months ago

Update: the service team has queued a bug in their backlog and slatted it for the current sprint. We expect the metadata change to be completed by March 8th, and then the rollout of the property to reach the SDK but the next week or the following.

baywet commented 5 months ago

Closing since the property is now available Thanks everyone for your patience!