microsoftgraph / msgraph-bicep-types

Repo contains Microsoft Graph resource types to integrate with bicep templates.
MIT License
45 stars 7 forks source link

Example in docs is missing provider microsoftGraph declaration #110

Closed slavizh closed 5 months ago

slavizh commented 6 months ago

The example here: https://learn.microsoft.com/en-us/graph/templates/quickstart-create-bicep-interactive-mode?tabs=CLI is missing provider microsoftGraph declaration to be added in the file which will cause to not see the resource providers for graph.

dkershaw10 commented 6 months ago

@slavizh I can see it mentioned twice in the quickstart. Maybe it's not prominent enough?

In the "Add a Microsoft Graph application group" it says: In main.bicep, type provider microsoftGraph, to let the Bicep compiler know that you're including Microsoft Graph types.

At the end of "Make the managed identity an owner of the group resource", it says: Your main.bicep file should now look something like:

provider microsoftGraph

param location string = resourceGroup().location
...

Please let me know what you think to make this more prominent, or resolve.

slavizh commented 6 months ago

Ok. I think than the misunderstanding mostly comes from here: image

The first one is just mentioned where the other example is shown as code block where you can do copy.

dkershaw10 commented 6 months ago

Fair enough, and I can see where the confusion comes from. I think we can make a simple change to update the 2nd code snippet to include the provider declaration.

dkershaw10 commented 5 months ago

@slavizh please take another look at the docs. If the latest updates fix the issue, please close, otherwise let me know what other things you need to see to address the issue.

slavizh commented 5 months ago

@dkershaw10 closing. I think now it is better. Thanks!