microsoftgraph / msgraph-cli-archived

The Microsoft Graph CLI repository has moved. This repository is now an archive.
https://github.com/microsoftgraph/msgraph-cli
Other
44 stars 9 forks source link

Log files with non-useful information #106

Closed MIchaelMainer closed 3 years ago

MIchaelMainer commented 3 years ago

Describe the bug We are creating log files with every call. The information in the log files are not useful and could be a potential source for data leakage if we aren't intentional with the data we emit to the logs.

An example of a login log entry:

CMD-LOG-LINE-BEGIN 16644 | 2021-05-10 15:59:38,789 | INFO | mg_command_data_logger | command args: login --scopes {} --debug
CMD-LOG-LINE-BEGIN 16644 | 2021-05-10 15:59:51,130 | INFO | mg_command_data_logger | exit code: 0

Log entries:

image

To Reproduce Steps to reproduce the behavior:

  1. Run any command.
  2. Go to c:\users\{user}\.mg\commands

Expected behavior We only emit log files when a user has opted-in to logging. The log files should contain useful information.

AB#9372