Move cloud commands to profile command group

microsoftgraph / msgraph-cli-archived

The Microsoft Graph CLI repository has moved. This repository is now an archive.

https://github.com/microsoftgraph/msgraph-cli

Other

44 stars 9 forks source link

Move cloud commands to profile command group #55

Closed jobala closed 3 years ago

jobala commented 3 years ago

Overview

Move commands from the cloud command group to the profile command group. Removes show-current commands from the cloud and graph-version command groups Adds show-profile command

Demo

Notes

N/A

Testing Instructions

Pull these changes
Build and run the docker container -- instructions are in README.md
Run mg profile -h to see the list of commands
Run mg profile show-profile to see your current profile

jobala commented 3 years ago

@MIchaelMainer I assume your comment below, is to help users get unstack when they run a wrong command.

Let's remove that ... and provide a user friendly message with specific instructions. Something like:

Where does the usage instructions fall short? It shows the commands available under the profile command group.

usage: mg profile [-h] {select-cloud,add-cloud,update-cloud,delete-cloud,select-version,show-profile

MIchaelMainer commented 3 years ago

The usage instructions part is good. I think we can make a friendlier, more helpful message than mg profile: error: the following arguments are required: _subcommand. I believe that a CLI experience should be somewhat conversational (I think I picked this up from the CLI guidance doc). That's why I proposed: The mg profile command must be used with a subcommand. Run mg profile -h for information on available subcommands.

jobala commented 3 years ago

Makes sense. The change won't be trivial so I have created #57 to track your suggestion.