Fix/ctr+c - Githubissues

microsoftgraph / msgraph-cli-archived

The Microsoft Graph CLI repository has moved. This repository is now an archive.

https://github.com/microsoftgraph/msgraph-cli

Other

44 stars 9 forks source link

Fix/ctr+c #80

Closed jobala closed 3 years ago

jobala commented 3 years ago

Overview

Add support for killing the CLI process with CTRL+C

Demo

N/A

Notes

N/A

Testing Instructions

Pull these changes
Run mg login --scopes user.read
Press CTRL + C
Observe that the process is terminated

Fixes #63

MIchaelMainer commented 3 years ago

I tried this from pwsh. Ran the command and the auth prompt in the browser opened. Ctrl+c didn't cancel the process and I had to manually close the pwsh instance. I take it that you aren't seeing this behavior, you used PowerShell 5 or the command prompt. My main dev machine crashed (not related) on me or else I'd try the other scenarios.

jobala commented 3 years ago

@MIchaelMainer this fails on Windows because azure-identity blocks and waits for a response once it opens the browser. I have created #18533 on the azure-identity repo to track the issue.

jobala commented 3 years ago

@MIchaelMainer based on the response from the thread in the azure-identity repo, I think we should merge this in and document that users should use CTRL+Break instead of CTRL+C on Windows. Let me know what you think.

jobala commented 3 years ago

@MIchaelMainer I have documented this under the wiki's known issues section.