Refactor validate function - Githubissues

microsoftgraph / msgraph-cli-archived

The Microsoft Graph CLI repository has moved. This repository is now an archive.

https://github.com/microsoftgraph/msgraph-cli

Other

44 stars 9 forks source link

Refactor validate function #98

Closed jobala closed 3 years ago

jobala commented 3 years ago

Overview

Refactors URL validation technique from making a request to using regex.

Demo

N/A

Notes

Making a request to validate the URL worked but was not the best approach for a number of reasons.

The user might be disconnected when registering a cloud
We were getting SSL verfication errors etc

Testing Instructions

Register a cloud with an incorrect url as the graph endpoint
Observe that you see an error message saying the graph endpoint is invalid

Fixes #89

Microsoft Reviewers: Open in CodeFlow

MIchaelMainer commented 3 years ago

Do we know why we were getting SSL verification issues? Was it occurring for all endpoints?

jobala commented 3 years ago

@MIchaelMainer recent versions of Python do not have certificates installed which causes this error. You can learn more from this SO post