search

microsoftgraph / msgraph-metadata

Microsoft Graph metadata captured and used for generating client library code files.
https://graph.microsoft.com
MIT License
99 stars 28 forks source link

Missing `if-match` header in the CSDL metadata #463

Open peombwa opened 10 months ago

peombwa commented 10 months ago

The CSDL is missing if-match header that's required when updating certain resources. The header should ideally be annotated by the API owners in their CSDL if it is required. The absence of these headers results in errors for customers consuming SDKs built on top of the CSDL.

The following resources are currently missing an If-Match header in the service description:

Originally opened at https://github.com/microsoftgraph/msgraph-sdk-powershell/issues/2328.

irvinesunday commented 10 months ago

Annotation needed to be updated for the two entities:

 <Annotation Term="Org.OData.Capabilities.V1.UpdateRestrictions">
  <Record>
    <PropertyValue Property="CustomHeaders">
      <Collection>
        <Record>
          <PropertyValue Property="Name" String="If-Match" />
          <PropertyValue Property="Description" String="ETag value." />
          <PropertyValue Property="Required" Bool="true" />
        </Record>
      </Collection>
    </PropertyValue>
  </Record>
</Annotation>
TaroxAG commented 4 months ago

@irvinesunday do you have an update on the issue?