search

microsoftgraph / msgraph-sdk-android

Microsoft Graph SDK for Android! https://graph.microsoft.io
Other
51 stars 43 forks source link

Upload a File should be able to receive an InputStream #16

Closed diogowbrito closed 7 years ago

diogowbrito commented 8 years ago

Right now, to upload a file a byte[] is required. This means the full contents of the file must be allocated in memory which may cause an OutOfMemoryError.

It would be a good enhancement to have the upload method receive an InputStream rather than a byte[].

thekindJose commented 8 years ago

Hi, any update on this issue?

peternied commented 8 years ago

@joseal82 We would be happy to review a pull request for this functionality. As of this time there is no planned support for InputStream in the SDK.

iambmelt commented 7 years ago

Large file upload introduced in #35 and released in 1.2.0

Thanks @daboxu for implementation, integration, and review assist.

Question for @daboxu: is there usage documentation available anywhere for large-file support we could link to for anyone who comes across this issue?

daboxu commented 7 years ago

@iambmelt a section about uploading large file is here: https://github.com/OneDrive/onedrive-sdk-android/blob/master/docs/items.md#upload-a-large-file

iambmelt commented 7 years ago

@daboxu Thanks!