search

microsoftgraph / msgraph-sdk-android

Microsoft Graph SDK for Android! https://graph.microsoft.io
Other
51 stars 43 forks source link

Bug fix and adding unit tests. #17

Closed TBag closed 8 years ago

TBag commented 8 years ago

Commit d38fe22: Bug fix for getOptions function in the BaseRequest class. Added mFunctionOptions to the LinkedList. Added unit tests for BaseRequest class.

Commit b9dde90: Adding unit tests for authentication, concurrency, core, http, logger, options, and serializer.

msftclas commented 8 years ago

Hi @TBag, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@TBag, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

iambmelt commented 8 years ago

It looks like there may be a few items worth digging into here, based on the results from running the tests on a 4.0.3 emulator.

junit.framework.AssertionFailedError
at com.microsoft.graph.concurrency.DefaultExecutorsTests.testPerformOnForegroundWithClientException(DefaultExecutorsTests.java:127)
at java.lang.reflect.Method.invokeNative(Native Method)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)
junit.framework.AssertionFailedError
at com.microsoft.graph.concurrency.DefaultExecutorsTests.testPerformOnForegroundWithProgress(DefaultExecutorsTests.java:99)
at java.lang.reflect.Method.invokeNative(Native Method)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)
junit.framework.AssertionFailedError
at com.microsoft.graph.concurrency.DefaultExecutorsTests.testPerformOnForegroundWithResult(DefaultExecutorsTests.java:68)
at java.lang.reflect.Method.invokeNative(Native Method)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)
junit.framework.AssertionFailedError
at com.microsoft.graph.concurrency.SynchronousExecutorTests.testExecute(SynchronousExecutorTests.java:24)
at java.lang.reflect.Method.invokeNative(Native Method)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)
peternied commented 8 years ago

:clock1:

peternied commented 8 years ago

:clock1:

peternied commented 8 years ago

The code changes look good, but there are problems running the tests on API 15 devices

com.microsoft.graph.concurrency.DefaultExecutorsTests > testPerformOnBackground[test(AVD) - 4.0.4] FAILED 
Test failed to run to completion. Reason: 'Instrumentation run failed due to 'java.lang.NoSuchMethodError''. Check device logcat for details
Tests on test(AVD) - 4.0.4 failed: Instrumentation run failed due to 'java.lang.NoSuchMethodError'
:graphsdk:connectedDebugAndroidTest FAILED
peternied commented 8 years ago

See #18 which should fix the executor test issues on an API15 device