search

microsoftgraph / msgraph-sdk-android

Microsoft Graph SDK for Android! https://graph.microsoft.io
Other
51 stars 43 forks source link

ANR when user selects `No` when asked for permissions #20

Closed diogowbrito closed 8 years ago

diogowbrito commented 8 years ago

If the user taps No while in the permissions screen (after user has already logged in) the application will get stuck. I'm using the MSAAuthAndroidAdapter and seems like no callback in called.

When Yes is tapped onAuthComplete(final LiveStatus status,…) is called. However, when tapping No then onAuthError(final LiveAuthException exception,…) is never called, leaving the app in an ANR state.

This is the related screen: permission_screen

iambmelt commented 8 years ago

@diogowbrito Thanks for reporting this issue; I'm able to reproduce this issue - I'm currently investigating and will update this thread with my findings as soon as possible.

/cc @peternied @shiftylogic

iambmelt commented 8 years ago

After an initial investigation; the error appears to be caused by this check in OfficeDev/msa-auth-for-android

screen shot 2016-07-01 at 10 20 08 am

I'll open an issue in this dependency project, and provide the link here once posted.

**edit

Associated project issue is now tracked here

/cc @diogowbrito

diogowbrito commented 8 years ago

Awesome, thanks @iambmelt 👍

iambmelt commented 8 years ago

Closing this issue. Please refer to msa-auth-for-android/issues/32 for tracking