v5 DriveItem is missing instance attributes

microsoftgraph / msgraph-sdk-dotnet

Microsoft Graph Client Library for .NET!

https://graph.microsoft.com

Other

704 stars 252 forks source link

Open olivermue opened 1 year ago

olivermue commented 1 year ago

Describe the bug According to the documentation each drive item can within a GET request return this value: @microsoft.graph.downloadUrl

Currently this property is not mapped within a DriveItem and must be extracted from the AdditionalData dictionary.

Expected behavior The DriveItem should have a corresponding property DownloadUrl.

andrueastman commented 1 year ago

The driveItem type does not include this in the metadata and thus would need to do so for the property to be projected.

MaximRouiller commented 1 year ago

@andrueastman driveItem is extended through an OData <Term> that is defined as:

<Term Name="downloadUrl" Type="Edm.String" AppliesTo="microsoft.graph.driveItem" />

It can be found in the metadata

mrfoster commented 1 year ago

I am also seeing other missing properties in V5 which is preventing an upgrade from V4.

I have no way of upgrading this V4 code as Thumbnails is missing from DriveItem

client
    .Sites[siteId]
    .Lists[listId]
    .Items[id]
    .DriveItem
    .Thumbnails;

IDriveItemRequestBuilder has now been replaced by a mixture of generated concrete types that are missing properties I am relying on.

andrueastman commented 7 months ago