search

microsoftgraph / msgraph-sdk-dotnet

Microsoft Graph Client Library for .NET!
https://graph.microsoft.com
Other
688 stars 246 forks source link

Inconsistency between documentation and SDK #1851

Open xskrasek opened 1 year ago

xskrasek commented 1 year ago

Describe the bug Example from documentation does not comiple.

_userClient.Sites["id"].Drive.Items

because Drive does not have an Items property.

Expected behavior Code compiles

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

andrueastman commented 1 year ago

Thanks for raising this @xskrasek

Any chance you can share a link to the documentation related to this?

xskrasek commented 1 year ago

Oh sorry, of course.

https://learn.microsoft.com/en-us/graph/api/driveitem-post-children?view=graph-rest-1.0&tabs=http

In my opinion, the paths for sites and code examples are confusing, as it is not consistent. Based on this post https://github.com/microsoftgraph/msgraph-sdk-dotnet/blob/dev/docs/upgrade-to-v5.md#drive-item-paths it is required that one gets the drive id from site and then works with it as a drive. But the paths in the documentation made me expect, that I can use the sites drive as a drive directly.

Especially since the API path contains children for sites, whereas the c# library does not.