microsoftgraph / msgraph-sdk-dotnet

Microsoft Graph Client Library for .NET!
https://graph.microsoft.com
Other
696 stars 247 forks source link

Drive Root does not contain Delta property #2231

Open adamijak opened 10 months ago

adamijak commented 10 months ago

Describe the bug Documentation here only mentions .../root/delta path. Sdk only allows you to use .../items/root/delta path, which is not documented.

Expected behavior Clear explanation which endpoint to use and how to use it.

Screenshots image

Client version 5.36.0

andrueastman commented 10 months ago

Thanks for raising this @adamijak

To confirm, the drives/{drive-id}/root is the same as drives/{drive-id}/items/root path in the API. The SDK only exposes one of them to avoid exposing too many paths due to the large number of paths as described at this doc.

https://github.com/microsoftgraph/msgraph-sdk-dotnet/blob/dev/docs/upgrade-to-v5.md#drive-item-paths

adamijak commented 10 months ago

Thank you. Now I can see the intention for not exposing too many paths. It would be nice to update documentation then.

andrueastman commented 10 months ago

@adamijak Just to clarify, which documentation would you say specifically would be needing updates?

adamijak commented 10 months ago

This one I would expect the HTTP request section to look like

GET /drives/{drive-id}/root/delta
GET /groups/{groupId}/drive/root/delta
GET /me/drive/root/delta
GET /sites/{siteId}/drive/root/delta
GET /users/{userId}/drive/root/delta
GET /drives/{drive-id}/items/{item-id | "root"}/delta
GET /groups/{groupId}/drive/items/{item-id | "root"}/delta
GET /me/drive/items/{item-id | "root"}/delta
GET /sites/{siteId}/drive/items/{item-id | "root"}/delta
GET /users/{userId}/drive/items/{item-id | "root"}/delta