microsoftgraph / msgraph-sdk-java

Microsoft Graph SDK for Java
https://docs.microsoft.com/en-us/graph/sdks/sdks-overview
MIT License
362 stars 125 forks source link

members subresource is missing under directoryRolesWithRoleTemplateId in 6.5.1 #1915

Open papegaaij opened 3 months ago

papegaaij commented 3 months ago

The Graph API supports listing members of a DirectoryRole via both its role-id and its roleTemplateId, like can be seen here: https://learn.microsoft.com/en-us/graph/api/directoryrole-list-members?view=graph-rest-1.0&tabs=http#http-request

In the new SDK, this would translate to these two statements:

client.directoryRoles().byDirectoryRoleId("roleId").members().get()
client.directoryRolesWithRoleTemplateId("roleTemplateId").members().get()

Of these, the first works fine, but the second is missing. DirectoryRolesWithRoleTemplateIdRequestBuilder does not have a members() method. In the Graph API, both constructs should behave identical, both for querying and manipulation (for example adding new members). The absence of this method forces us to split the call in two: first get the directory role by template id and then perform the actual operation.

andrueastman commented 3 months ago

Depends on https://github.com/microsoft/OpenAPI.NET.OData/issues/459