search

microsoftgraph / msgraph-sdk-java

Microsoft Graph SDK for Java
https://docs.microsoft.com/en-us/graph/sdks/sdks-overview
MIT License
371 stars 125 forks source link

Channel isArchived is missing #2100

Open BradPlayerZero opened 1 month ago

BradPlayerZero commented 1 month ago

Describe the bug

According to the documentation, channels are supposed to have an isArchived flag. See https://learn.microsoft.com/en-us/graph/api/team-list-allchannels?view=graph-rest-1.0&tabs=http.

Unfortunately, this API doesn't have the isArchived flag in channels. See https://github.com/microsoftgraph/msgraph-sdk-java/blob/fdd899b62b31fbb637b25d9b4bab11d49a0060ee/src/main/java/com/microsoft/graph/generated/models/Channel.java#L11

Not sure how this can happen, as this is supposed to be autogenerated code.

Note the isArchived flag is in the msgraph-beta-sdk-java sdk, see https://github.com/microsoftgraph/msgraph-beta-sdk-java/blob/346c3d15d975a8d1a9d8ee0b4cbf70f7d3ccd6fc/src/main/java/com/microsoft/graph/beta/generated/models/Channel.java#L11

As the isArchived flag doesn't seem updated recently, there doesn't seem any logical reason for the omission.

Expected behavior

Channels should have an isArchived flag

How to reproduce

Observe the channel object is missing the isArchived property

SDK Version

No response

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output

Click to expand log ``` ```

Configuration

No response

Other information

No response

baywet commented 1 month ago

Hi @BradPlayerZero Thanks for using the SDK and for reporting this. I've created an incident for the relevant service team (you won't be able to access this link) https://portal.microsofticm.com/imp/v3/incidents/incident/528182959/summary

This is most likely to take a couple of weeks, the schema changes are locked for security reasons. (we use the schema to generate the SDK)

BradPlayerZero commented 1 month ago

@baywet - not following. Schema seems publicly available here: https://raw.githubusercontent.com/microsoftgraph/msgraph-metadata/master/openapi/v1.0/openapi.yaml. Why is there a security issue with the java SDK not using an up-to-date version of that specification?

baywet commented 1 month ago

I might have going a bit fast in my explanation here and have assumed context most people don't have.

Here is how any change makes it to the SDKs:

  1. service team makes a change to the (CSDL) schema.
  2. Microsoft Graph service team publishes that schema and hands it over to our team (devx)
  3. We convert it from CSDL to OpenAPI (the document you linked)
  4. We use kiota to generate the SDKs in all languages
  5. We eventually release the new versions.

Where I had wrongly thought we were missing step 1, it's actually step 4 that needs to happen at this point. (sorry about the confusion) However we're on a weekly release freeze until the end of August due to having a lot of personnel on vacations.