search

microsoftgraph / msgraph-sdk-java

Microsoft Graph SDK for Java
https://docs.microsoft.com/en-us/graph/sdks/sdks-overview
MIT License
387 stars 132 forks source link

Improve default RetryHandler implementation #2186

Open Geiste opened 1 month ago

Geiste commented 1 month ago

Is your feature request related to a problem? Please describe the problem.

SDK V5 As per incident: 2409111420000033 in case there is a low memory on server side the server returns 503 for other error codes.

In such cases SDK treats 404, 403 errors as if it is 503 and retries.

We were instructed by Microsoft support person of contact to implement RetryHandler on application side and retry only if "retry-after" header is present. However, it sounds like this should be handled in SDK side rather than us.

Describe the solution you'd like.

I would propose such cases, when Microsoft servers have low memory to be handled by SDK

Additional context?

No response

Ndiritu commented 1 month ago

Hi @Geiste, are you referencing an IcM incident number? I'm unable to find one with that number. Please share a link.

Unfortunately we are currently only doing security patches for v5 and would recommend you upgrade to v6 of the SDK which correctly handles retries

Geiste commented 1 month ago

Hi,

Thank you for your answer.

We are currently upgrading to v6 and will finalize soon, so if retries are handled correctly in that version then its fine. Thank you :)

On Tue, 8 Oct 2024 at 03:18, Philip Gichuhi @.***> wrote:

Hi @Geiste https://github.com/Geiste, are you referencing an IcM incident number? I'm unable to find one with that number. Please share a link.

Unfortunately we are currently only doing security patches for v5 and would recommend you upgrade to v6 of the SDK which correctly handles retries

— Reply to this email directly, view it on GitHub https://github.com/microsoftgraph/msgraph-sdk-java/issues/2186#issuecomment-2398260998, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3BE4RLEWCUAPMC5PG2FGLZ2MQENAVCNFSM6AAAAABPPCEPTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJYGI3DAOJZHA . You are receiving this because you were mentioned.Message ID: @.***>