search

microsoftgraph / msgraph-sdk-javascript

Microsoft Graph client library for JavaScript
https://graph.microsoft.com
MIT License
730 stars 220 forks source link

- tsconfig-test-development.json - added isolatedModules: true #1661

Open mehonja opened 3 months ago

mehonja commented 3 months ago

Motivation

https://github.com/microsoftgraph/msgraph-sdk-javascript/issues/1535

Test plan

All tests work, added isolatedModules to development tests.

Closing issues

Fixes https://github.com/microsoftgraph/msgraph-sdk-javascript/issues/1535

Types of changes

-> Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I have read the CONTRIBUTING document. My code follows the code style of this project. My change requires a change to the documentation. I have updated the documentation accordingly. I have added tests to cover my changes. All new and existing tests passed.

mehonja commented 3 months ago

@microsoft-github-policy-service agree

Overdash commented 2 days ago

Any update on this PR? This typescript issue seems to affect Next.js 14 projects since isolatedModules is recommended to be set to true.