search

microsoftgraph / msgraph-sdk-objc

Microsoft Graph SDK for Objective-C
MIT License
37 stars 21 forks source link

Nullability Issues - Xcode 10.3 #36

Open SteveDCronin opened 5 years ago

SteveDCronin commented 5 years ago

I'm using Xcode 10.3 on macOS 10.14.5 I'm using CocoaPods to manage dependancies. I've used both: pod 'MSGraphClientSDK' and pod 'MSGraphMSALAuthProvider' There are 37 Nullability Issue warnings (double that when using 'MSGraphMSALAuthProvider'). They're a real nuisance in an otherwise tight clean compile! It may be that they can be ALL be cured by simply placing 'NS_ASSUME_NONNULL_BEGIN' & 'NS_ASSUME_NONNULL_END' macros around the 7 interface declarations in MSGraphMiddleWare.h, MSHTTPClient.h, MSURLSessionTask.h, MSBatchRequestStep.h, MSBatchResponseContent.h, MSLargeFileUploadTask.h, MSGraphOneDriveLargeFileUploadTask.h. If the macros won't work then adding nullability to the various method signatures is pretty straightforward! Don't be lazy! Please provide more carefully constructed code. AB#6087

MIchaelMainer commented 5 years ago

Thank you for the feedback. We've added this to our backlog.

RegisStGelais commented 4 years ago

Any time table on this issue ?

macdrevx commented 2 years ago

Continuing to see a number of nullability warnings when building with Xcode 14.1 beta 3:

Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)
Block pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)