search

microsoftgraph / msgraph-sdk-php

Microsoft Graph Library for PHP.
Other
551 stars 141 forks source link

Add config for release please. #1532

Closed SilasKenneth closed 1 month ago

SilasKenneth commented 1 month ago
Microsoft Reviewers: Open in CodeFlow
SilasKenneth commented 1 month ago

I would recommend using something other than 

```json

to avoid the red highlighting for comments in json Screenshot 2024-05-22 154041

That's the reason I used json5. We can also use js. What do you think @baywet?

baywet commented 1 month ago

@SilasKenneth have you tried jsonc (json with comments) ? I don't have a strong opinion either way. I didn't know json5 was a thing until your last message, sorry for creating confusion here. https://json-5.com/json-vs-json5

SilasKenneth commented 1 month ago

@SilasKenneth have you tried jsonc (json with comments) ? I don't have a strong opinion either way. I didn't know json5 was a thing until your last message, sorry for creating confusion here. https://json-5.com/json-vs-json5

I just tried it now. Looks like it achieves the desired output too.