search

microsoftgraph / msgraph-sdk-php

Microsoft Graph Library for PHP.
Other
575 stars 144 forks source link

Missing Enum in DeviceEnrollmentType (Beta) #375

Closed tomw-ucb closed 3 years ago

tomw-ucb commented 3 years ago

Hi MS team,

Recently we have enrolled our HoloLens 2 onto Intune and our application could not handle the enrollment type. We are using msgraph-sdk-php v1.25.0

The class Beta\Microsoft\Graph\Model\DeviceEnrollmentType is missing the enumeration value for windowsAzureADJoinUsingDeviceAuth

Can you please add this enum value ?

Thank you in advance,

Tom AB#7841

MIchaelMainer commented 3 years ago

This will be in the next release. It is currently available in dev.

https://github.com/microsoftgraph/msgraph-sdk-php/blob/dev/src/Beta/Microsoft/Graph/Model/DeviceEnrollmentType.php

tomw-ucb commented 3 years ago

Hi @MIchaelMainer

The class does contain a value for "windowsAzureADJoin", but it does not contain a value for "windowsAzureADJoinUsingDeviceAuth".

KR Tom

MIchaelMainer commented 3 years ago

I'm sorry that I missed that windowsAzureADJoinUsingDeviceAuth was missing. That enum is neither documented nor contained in the metadata https://graph.microsoft.com/beta/$metadata. What is your source for that missing enum value? Are you seeing it in a response?

https://docs.microsoft.com/en-us/graph/api/resources/intune-shared-deviceenrollmenttype?view=graph-rest-beta

tomw-ucb commented 3 years ago

Yes, the Graph API (beta) returns the attached response on the endpoint : https://graph.microsoft.com/beta/deviceManagement/managedDevices/{{managedDeviceId}}

ManagedDevice_Details_HoloLens2.json.txt

zengin commented 3 years ago

This is fixed in version 1.27.0 as of now:

https://github.com/microsoftgraph/msgraph-sdk-php/blame/1.27.0/src/Beta/Microsoft/Graph/Model/DeviceEnrollmentType.php#L42