microsoftgraph / msgraph-sdk-powershell

Powershell SDK for Microsoft Graph
https://www.powershellgallery.com/packages/Microsoft.Graph
Other
713 stars 171 forks source link

Passing jsons in POST/PATCH requests is not administrator friendly #2943

Open nilakhan opened 2 months ago

nilakhan commented 2 months ago

Is your feature request related to a problem? Please describe the problem.

We have a set of cloud printing APIs exposed in Microsoft Graph.

Currently Graph generated powershell requires users to provide inputs for POST/PATCH requests as json, which is developer friendly but not admin friendly. e.g. following is the comparison of Universal Print operations using custom Universal Print powershell module and Graph generated powershell module for sharing printer.

Universal Print powershell module: New-UPPrinterShare -PrinterId "cdd44642-8fc3-4f55-bce2-d6d8069b40f2" -ShareName "First Floor Printer"

Graph generated powershell module: $params = @{ DisplayName = "ShareName" AllowAllUsers = $false Printer@odata.bind = https://graph.microsoft.com/v1.0/print/printers/{printerId} }
New-MgPrintShare -BodyParameter $params

Hence, requesting Graph powershell team to address this concern. This is blocking our team from deprecating Universal Print powershell module in favor of Graph generated powershell module.

Describe the solution you'd like.

Admins can provide required info as named parameters instead of jsons. e.g. consider Universal Print custom powershell module command for sharing printer:

New-UPPrinterShare -PrinterId "cdd44642-8fc3-4f55-bce2-d6d8069b40f2" -ShareName "First Floor Printer"

Additional context?

No response

timayabi2020 commented 1 month ago

@nilakhan thank you for proposing this feature of flattening the Json body into request parameters. We will look into it and hopefully come up with a solution that is friendly to the user as you have stated. @CarolKigoonya