search

microsoftgraph / msgraph-sdk-powershell

Powershell SDK for Microsoft Graph
https://www.powershellgallery.com/packages/Microsoft.Graph
Other
701 stars 168 forks source link

devicemanagement.enrolment module has entitlement management cmdlets #842

Closed markwahl-msft closed 2 years ago

markwahl-msft commented 3 years ago

It is confusing that there are cmdlets for managing entitlement management roles in the Microsoft.Graph.DeviceManagement.Enrolment package, such as "Get-MgRoleManagementEntitlementManagementRoleDefinition". I would expect them in either identity governance or unified RBAC.

I believe this may originate from the modulemapping file in which the line for 1DeviceManagement.Enrolment includes

^roleManagement\\.",

this is too broad a namespace since Graph role management https://docs.microsoft.com/en-us/graph/api/resources/rolemanagement?view=graph-rest-beta currently supports the following RBAC providers in Microsoft 365:

but only the 2nd of the 4 are relevant to this module. This line should be changed in

https://github.com/microsoftgraph/msgraph-sdk-powershell/blob/92cfeb72b714e24a0b2b700a7c49aa30585ae12c/config/ModulesMapping.jsonc#L13

to allow other modules to have their rolemanagement cmdlets relevant to them.

peombwa commented 2 years ago

We will address this in v2 of the SDK since changing it now would result in a breaking change. Is there someone from the workload team we can work with to help with the module classification?

cc\ @maisarissi

peombwa commented 2 years ago

Fixed by #1573