search

microsoftgraph / msgraph-sdk-python

MIT License
373 stars 54 forks source link

Wrong options given for devicecodecredential #663

Closed bvduijn closed 5 months ago

bvduijn commented 6 months ago

https://github.com/microsoftgraph/msgraph-sdk-python/blob/31d632610b5969439dfe406cb34301a816250735/README.md?plain=1#L66

According to the options specified for devicecodecredential the tenantID is a keyword only parameter. The line should be:

credentials = DeviceCodeCredential(client_id, 
                                   tenant_id=tenant_id )
shemogumbe commented 5 months ago

Thanks for raising this, for delegated flow, you can use both keywoord and positional arguments, should they positional, the order to be client_id, tenanant id, for keyword arguments which is a good preferance, put them whenere. Did you find a bug using tenant_id as a positional argument?

microsoft-github-policy-service[bot] commented 5 months ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.