search

microsoftgraph / msgraph-sdk-python

MIT License
359 stars 49 forks source link

Please add CRUD methods to RangeWithAddressRequestBuilder subclass and please re-add "values" property to WorkbookRange subclass #844

Open dianalingtung opened 1 month ago

dianalingtung commented 1 month ago

Is your feature request related to a problem? Please describe the problem.

With version 1.5.4, I am unable to perform CRUD operations against a user-defined Excel worksheet range address (i.e., A1:B2) using the RangeWithAddressRequestBuilder and WorkbookRange subclasses in the Python SDK. Specifically, I am unable to read, update, and delete Excel worksheet cell data in a user-defined range address. Please note that I am able to perform these actions using Graph Explorer.

Describe the solution you'd like.

  1. Can PATCH and DELETE methods be added to the RangeWithAddressRequestBuilder subclass?
  2. Can the "values" property be re-added to the WorkbookRange subclass?

Additional context?

  1. Currently, the RangeWithAddressRequestBuilder subclass has methods to build a GET request that is sent to the MS Graph API, but this subclass does not have update or delete methods to send PATCH or DELETE requests.

  2. In the recently updated Python SDK, the WorkbookRange subclass no longer contains the "values" property. Previously, with the "values" property, a GET request could be sent to retrieve raw values from a given Excel range address in the Python SDK. Now that the "values" property is no longer in the WorkbookRange subclass, a user can no longer submit a GET request for raw values at a given range address.

shemogumbe commented 1 month ago

Hello @dianalingtung thanks for raising this.

On Values property: - this was removed as it gave challenges with serialization considering the type information was wrong, the values property for now can be obtained from the additional_data

dianalingtung commented 1 month ago

Hello @dianalingtung thanks for raising this.

On Values property: - this was removed as it gave challenges with serialization considering the type information was wrong, the values property for now can be obtained from the additional_data

@shemogumbe Shem,

Thank you for the response.

While the values property can be obtained from the additional_data property for now, is there any chance you could add PATCH and DELETE methods for the RangeWithAddressRequestBuilder? Is there an alternative request builder method that could be called to PATCH/DELETE (for example by referencing a raw Graph API call)?

Thank you,

Diana