microsoftgraph / msgraph-sdk-serviceissues

Tracks service issues for follow up.
5 stars 0 forks source link

CreateLink for item with provided Id sends improper query to SharePoint resulting in incorrect error. #94

Open fishinstew opened 4 years ago

fishinstew commented 4 years ago

While providing an _itemId to Graph an improper query is executed vs SharePoint and an incorrect error is bubbled up through Graph.

Steps To Reproduce: With an authenticated Microsoft.Graph.GraphServiceClient, perform the following action vs a SharePoint site with > 5,000 items.
await GraphClient.Sites[_siteId].Drives[_driveId].Items[_fileId].CreateLink("view", "anonymous").Request().WithMaxRetry(0).PostAsync();

Observations:

`

{b9d187fb-6b52-4e54-9553-e5605b982a3c}
<ViewFields>
    <FieldRef Name='owshiddenversion'/>
    <FieldRef Name='SharingDocId'/>
    <FieldRef Name='CurrentLink'/>
    <FieldRef Name='AvailableLinks'/>
</ViewFields>
<RowLimit Paged="TRUE">2147483647</RowLimit>

`

Expected Behavior:

  1. When providing an _itemId and calling "CreateLink" the recursive all query should not be executed vs. the SharePoint instance to locate the item. Instead a more direct query should be made to both improve efficiency and prevent problems with larger SharePoint sites.
  2. When a ListView threshold error is thrown by SharePoint, a more correct error should be returned via the GraphApi with the SharePoint exception nested as an Inner Exception to prevent $ and Time being lost. AB#7243
MIchaelMainer commented 4 years ago

@JeremyKelley This appears to be an issue with SharePoint+Graph service when creating an anonymous sharing link.

petrhollayms commented 5 months ago

Thank you for reporting this issue. This appears to be an issue or limitation with the service APIs. Unfortunately, as the Microsoft Graph SDK team, we do not have ownership of the APIs that are causing you issues. We invite you to create a question about the service API to Microsoft Q&A and tagged with one of the [microsoft-graph-*] tags, that way it will get routed to the appropriate team for them to triage:

https://aka.ms/msgraphsupport or directly https://aka.ms/askgraph

For now, we will close the issue on our side but feel free to open it in the relevant repository if you think the issue is specific to SDK. Please let us know if this helps!

Note: We will close this repository on April 19, 2024.