search

microverseinc / linters-config

248 stars 1.25k forks source link

Update `runs-on` configuration for all jobs #206

Closed teckim closed 2 years ago

teckim commented 2 years ago

Update OS for all actions running on Ubuntu

20 days ago GitHub actions announced that the Ubuntu 18.04 os is no longer supported, and it will be fully deprecated on 12/1/2022. Until then all the actions that run on Ubuntu 18.04 will be queued for some time.

The fix that I introduced is to change all runs-on: ubuntu-**-** into runs-on: ubuntu-latest to avoid any future deprecation.

related issue: #205

bellom commented 2 years ago

Thank you @teckim - linters.yml file has been updated!

teckim commented 2 years ago

Thank you @teckim - linters.yml file has been updated!

Happy to hear that you have updated the files @bellom, but I suggest using runs-on: ubuntu-latest to avoid any deprecation in the future.

bellom commented 2 years ago

@teckim - thanks for the feedback, however, we might need to stick to using version number because sometimes the latest version of ubuntu might not work with the rest of the configuration in the linters.yml file.

Ex: ubuntu 22.04 didn't work with ruby 3.0.x, so we had to update the ruby version to 3.1.x