microverseinc / linters-config

248 stars 1.25k forks source link

Update to Node version 18 for linters config #221

Closed bellom closed 1 year ago

bellom commented 1 year ago

Linter: node would be deprecated next year summer, we start to get warnings for now. GitHub documentation

@nidalaa @NoerGitKat

shasherazi commented 1 year ago

Thanks, @bellom, for the PR, and thanks, @ahangarha, for the approval.

This old version has given many Micronauts (including me) a hard time with GitHub actions. We had no other way to ignore the error with eslint-disable. For example, this failed GitHub actions check is appearing a lot. Node 12 is a really old version indeed (from 2019, 4 years old!). It should be updated to the current LTS version, 18.x.

If you're feeling adventurous, then you can use some preconfigured GitHub action such as Lint Action or Super-Linter.

shasherazi commented 1 year ago

Hi,

Many students are facing an eslint issue that is potentially caused by using an older node version. This pull request needs @nidalaa's review. Can we please approve these changes so that students can work without facing issues happening due to older node and linter versions?

EDIT: Today's problem was caused by some esquery update, but it's still good to have the lts version in GitHub actions.

NoerGitKat commented 1 year ago

Hey there @bellom @shasherazi @ahangarha,

Thanks for taking the initiative in preparing this pull request. Per @ahangarha's suggestion, we should update to version 18 instead since GitHub Actions already supports it.

If any of you could do that I will approve on behalf of @nidalaa and we can close this PR!

shasherazi commented 1 year ago

On a related note, the package versions are pretty old too. There are a lot of warnings about deprecated packages when installing linters locally. But maybe that's for another PR.

bellom commented 1 year ago

@NoerGitKat - I have updated to version 18, you can go ahead and merge, thanks.

bellom commented 1 year ago

@shasherazi Yes, that's correct, I will create another PR for that.

Thanks for the reminder 👍