MS:5 - Friendship v1 - Githubissues

microverseinc / ror-social-scaffold

This repo includes intial code for social media app. Its purpose is to be a starting point for Microverse students.

67 stars 516 forks source link

MS:5 - Friendship v1 #353

Closed marijanbrvar closed 3 years ago

marijanbrvar commented 3 years ago

In this milestone, we implemented the following user requirements

I want to be able to send a friendship invitation.
I want to see a button “Invite to friendship.”
I want to be able to see pending friendship invitations sent to me from other users
I want to be able to accept or reject friendships' invitation.

We create a model with associations and all requested features for friendships.

euqueme commented 3 years ago

Hi @marijanbrvar and @zilton7 :wave: this is the wrong branch the PR has to be done from your feature branch to your development branch something like this: marijanbrvar:friendship-v1 into marijanbrvar:development

if you already requested another review please :pray: edit this PR description and include the link to the correct PR

I'm closing this :no_entry:

marijanbrvar commented 3 years ago

Hi Maria I am so sorry for producing such a hassle. I see what you are talking g about. Please will you be so kind as to close the current code review for this project. Our current project status is Waiting for review, and I cannot resubmit the new PR again. See picture in attachment. Thank you very much, and I am sorry again for my ignorance!

Screen Shot 2021-04-20 at 20 04 59

euqueme commented 3 years ago

@andresporras3423 the students didn't close it I did because it's not following the right flow.

@marijanbrvar please :pray: make the changes suggested by @andresporras3423 in a new PR that goes from your feature branch to your development branch, do not use this PR again thank you :pray: