search

micz / ThunderAI

ThunderAI is a Thunderbird Addon that uses the capabilities of ChatGPT or Ollama to enhance email management.
https://micz.it/thunderbird-addon-thunderai/
GNU General Public License v3.0
31 stars 8 forks source link

Substitute text button replaces the e-mail text with "3.5" + prompt issues #84

Closed jakubstaszak-com closed 3 months ago

jakubstaszak-com commented 3 months ago

Substitute text button replaces the e-mail text with "3.5"

Here's the demo along with other suggestions: https://mega.nz/file/C4FmnCYQ#6cD4jiCd5Zo7bN59p8axkS49SVxs2GxfjI0bSKU-zOY

Here's more details after you tried to replicate the issue: https://mega.nz/file/r0cWWDZb#q1MEZCzldKZw0sklRrRU12hokjatDpJltrhsSEx7HjI

micz commented 3 months ago

Thank you Jakub for your videos! They are rally useful to understand what's going on. I think I get the translate part of the problem, and I added issues #85 and #86.

To do not get useless text in the response, look at the default prompts, where there is the statement: "Reply with only the re-written text and with no extra comments or other text.". If you add this to your prompt, maybe it could help. The double quotes are stripped when imported in Thunderbird.

In regard to the 3.5 problem, I'm now getting this consintently. The addon works only if you check the "keep formatting" option. I'll work on this later. I added issue #87. I'm going to update also the service status page.

I'm now closing this issue, but feel free to comment here or on the other issues as you wish. Thank again for your help.

micz commented 3 months ago

Version 1.2.1pre1 should fix everything: https://github.com/micz/ThunderAI/releases/tag/v1.2.1pre1

May you test it and report here the result? Thank you!!

micz commented 3 months ago

I released version 1.2.1: https://github.com/micz/ThunderAI/releases/tag/v1.2.1

Let me know! Thank you.

jakubstaszak-com commented 3 months ago

I released version 1.2.1: https://github.com/micz/ThunderAI/releases/tag/v1.2.1

Let me know! Thank you.

It now works perfectly without any issues.

I can only see that new lines are now lost between selected text when redacting an e-mail and a prompt which is automatically created.

Is my assumption correct, that it's due to the "keep formatting" option you've mentioned being now disabled by default?

Just translated my first e-mail with your addon ant it's super useful already :)

Thank you!

micz commented 3 months ago

I can only see that new lines are now lost between selected text when redacting an e-mail and a prompt which is automatically created.

Is my assumption correct, that it's due to the "keep formatting" option you've mentioned being now disabled by default?

I've not changed how the "Keep formatting" works in this version. It's disabled by default since the first time I implemented it per user request. May you explain what's happening? Thank you.