midas-network / midas-data

An ontology for MIDAS data types
1 stars 2 forks source link

Style #34

Closed LucieContamin closed 1 year ago

LucieContamin commented 1 year ago

The different terms can be written in different "style", for example:

Should we choose one "style" to avoid confusion?

hoganwr commented 1 year ago

The issue is that we do not use upper case in Apollo-SV, whereas the MIDAS OWL file was created using some upper case characters.

If we want to have a single style, we could either (1) adapt MIDAS OWL file terms to the Apollo-SV convention (which is constrained by OBO Foundry conventions, so not malleable) or (2) create a new annotation property like "MIDAS preferred name" and enforce consistent style on that property.

On Thu, Jul 28, 2022 at 5:47 PM Lucie Contamin @.***> wrote:

The different terms can be written in different "style", for example:

  • Case counts (first letter upper case)
  • Diagnostic Tests (first letter of each word in upper case)
  • infection case list (lower case)
  • sequence_collection (lower case and "special character")

Should we choose one "style" to avoid confusion?

— Reply to this email directly, view it on GitHub https://github.com/midas-network/midas-data/issues/34, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJR55SZBHLKIRPYWDUPSDDVWL5VNANCNFSM546XUPIQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

harryhoch commented 1 year ago

I'm ok with simply revising labels to fit the Apollo-SV approach