midas-research / man-sf-emnlp

61 stars 14 forks source link

potential bug #2

Open dotchen opened 3 years ago

dotchen commented 3 years ago

Here https://github.com/midas-research/man-sf-emnlp/blob/main/train.py#L107-L109,

Why is this F.softmax? should the right thing be F.log_softmax?

reference: https://pytorch.org/docs/1.9.0/generated/torch.nn.functional.nll_loss.html