Several bugs with t!set and t!setuser

midblue / timezone-bot

🌐 Timezone notifier bot for Discord

https://discord.com/api/oauth2/authorize?client_id=437598259330940939&permissions=68672&scope=bot

42 stars 18 forks source link

Several bugs with t!set and t!setuser #81

Open cobrabr opened 2 years ago

cobrabr commented 2 years ago

The screenshots below illustrate a few of the problems I found trying to set time zone, both for myself (with t!set) and for other users (with t!setuser).

Using time zone codes and UTC/GMT codes:

EDT is the only correct one here (and even then, not exactly, since we're not in Daylight Savings Time anymore).
'UTC-8' is correct here, the rest isn't.

Dealing with ambiguous city names

Not sure where the bot is getting "Central Time" from "Barcelona" or "CET" here. Trying to be more specific (as the screenshot shows) doesn't work. I tried used quotes, but that doesn't work, either.
This only applies to t!setuser; t!set works with both city, country and fully-spelled time zones.

zsawyer commented 2 years ago

Section 1 relates to #79: possibly duplicate.

bouncingmolar commented 2 years ago

I tested the setuser bug.

Setuser only recognises place names that have one word.

New Zealand. Barcelona, Spain. South Korea. North Carolina would trigger the bug.

The problem is t!setuser user place1 place2 the bot reads name=(name place1) location=(place 2).

The problem with locations containing more than one word doesn't seem to affect t!set

bouncingmolar commented 2 years ago

The other issues mentioned are described in the bot instructions. They will not be fixed. The work around is to use City/country names. Tell your members this or setuser correct them.

One problem with setting UTC offsets and time zone codes is that they won't adjust when daylight changes to summer time so half the time the time will be wrong.

I.e. if you set EDT, it won't change to EST when it should.

cobrabr commented 2 years ago

Sounds good. The only reason I tried to use time zone codes or UTC offsets was to try and circumvent the problem with place names that have more than one word.

bouncingmolar commented 2 years ago

A work around for setuser (because t!set Barcelona, Spain works). Is to try a nearby City or just Spain eg. t!setuser Spain or t!setuser stiges (a town near Barcelona) or Andorra. Barcelona doesn't work by itself because it clashes with Barcelona in Venezuela, England, Phillipines........ Etc. At least until the bug is fixed to allow spaces

cobrabr commented 2 years ago

Yep, that's what I did: I used Madrid. Thanks for the help!