search

middlebury / coursecatalog

This Course-Catalog is a project to develop a web front-end for searching and browsing course information stored in Banner.
https://github.com/middlebury/coursecatalog/wiki
GNU General Public License v3.0
9 stars 2 forks source link

Order meeting times by date #29

Closed adamfranco closed 4 years ago

adamfranco commented 4 years ago

Bob Cole:

@afranco a hub UX question for you - a prof was concerned about the presentation of course schedule info on her hub dashboard. See: https://courses.middlebury.edu/hub/miis/202028/icco/8535a

The schedule presents meeting days and times in reverse order, and also seems to favor the day of the week over month and day. Not sure what the sort order is, but imagine it could be confusing to some who might rely on hub for this info, at start of classes.

In Banner it looks like this: Screen Shot 2020-02-06 at 11 03 05 AM

I can file a ticket, she also indicates that the data for ICCO is correct, but the cross-listed site for the same course is in-correct: https://courses.middlebury.edu/hub/miis/202028/educ/9535a

So, there's a combination of issues. UX and correct data. Banner info for EDUC 9535 is correct.

GetAttachmentThumbnail

Adam Franco 2:22 PM

Thanks for reporting this, Bob. That is certainly a complex case. That string is being generated here: https://github.com/middlebury/coursecatalog/blob/master/application/library/banner/course/CourseOffering.php#L480-L526 And here for loading the entries: https://github.com/middlebury/coursecatalog/blob/master/application/library/banner/course/CourseOffering/AbstractSession.php#L268-L310 Right now these aren’t ordered, but that can change.

adamfranco commented 4 years ago

The schedule is now reordered by start-date and I've started the week on Monday.

Before: Before

After: after

beohbe70 commented 4 years ago

@adamfranco thanks for the attention on this. When will the re-order sync over with the Hub?

adamfranco commented 4 years ago

Thanks for the ping on that. It would have updated tomorrow morning, but I kicked off the update early: https://courses.middlebury.edu/hub/miis/202028/icco/8535a now has the new format.

adamfranco commented 4 years ago

The EDUC 9535a version wasn't updated because this is no longer an enrollable course and no longer in the data feed. It can be deleted here, but it does have a Canvas site attached.