search

middlebury / frontend

Frontend code for institute_theme
GNU General Public License v3.0
0 stars 0 forks source link

using text component for profile listing heading has issues #101

Closed zebapy closed 6 years ago

zebapy commented 6 years ago

Since profile "listings" are just multiple profile components separated by text components used as a heading, the design falls down now that all text paragraphs have significant bottom margin.

screenshot 2018-01-30 16 22 43

imcbride commented 6 years ago

The text paragraphs will often just be headings, but they don't necessarily have to be. Editors might choose to include regular paragraphs of text explaining roles or providing generic contact information for departments.

zebapy commented 6 years ago

Per discussion, sounds like we'll possibly create a Profile Listing Heading component specifically for this unless an alternative css fix can be done.

imcbride commented 6 years ago

Fixed in https://github.com/middlebury/drupal8/commit/5634c9569c0fd70c01d44fe0a5234f77400f502b