search

middlebury / frontend

Frontend code for institute_theme
GNU General Public License v3.0
0 stars 0 forks source link

Events component - text runs over each other #138

Closed ghost closed 6 years ago

ghost commented 6 years ago

https://www.middlebury.edu/institute/academics/academic-resources/digital-learning-commons

Long titles are not wrapping when we have a crazy long word. This one is an easy fix (add a space) - but thoughts on this when there is a legit long word?

zebapy commented 6 years ago

We should talk more in person with Ari about this as the outcomes for adding fixes for this seem less than ideal.

For now, at least the text breaks.

screenshot 2018-03-14 10 58 03

ghost commented 6 years ago

I think we should avoid three cols and do the vertical presentation for this component. I think that would solve a few issues.

From: Zeb Pykosz notifications@github.com Sent: Wednesday, March 14, 2018 11:09:00 AM To: middlebury/frontend Cc: Smith, Aaron P.; Assign Subject: Re: [middlebury/frontend] Events component - text runs over each other (#138)

Notice: This email is from an external sender. Please use caution before clicking links or opening attachments.

We should talk more in person with Ari about this as the outcomes for adding fixes for this seem less than ideal.

For now, at least the text breaks.

[screenshot 2018-03-14 10 58 03]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F2199845%2F37410956-0c16cc50-2778-11e8-9b0d-24d4cef4b310.png&data=02%7C01%7Caarons%40middlebury.edu%7Ca013f190d834424fc3c708d589bd847d%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C636566369422496846&sdata=h5UdTOnaD4lce7x1WeBrBr55%2Fe5ARhspYSDqWBq9D0c%3D&reserved=0

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmiddlebury%2Ffrontend%2Fissues%2F138%23issuecomment-373055686&data=02%7C01%7Caarons%40middlebury.edu%7Ca013f190d834424fc3c708d589bd847d%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C636566369422496846&sdata=LwizWyJFBcCSgnX03dFV%2BrolfOJhTep5bmDjfZVggZk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALmEI7DQmXEB5BzhnTHeFSIrkQpaHF60ks5teTKMgaJpZM4SqeyY&data=02%7C01%7Caarons%40middlebury.edu%7Ca013f190d834424fc3c708d589bd847d%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C636566369422496846&sdata=mKZ7CUBygT7FOAIwowPgFW9xtnhy555KE234hNM0JDs%3D&reserved=0.

imcbride commented 6 years ago

See https://github.com/middlebury/drupal8/issues/145