search

middlebury / frontend

Frontend code for institute_theme
GNU General Public License v3.0
0 stars 0 forks source link

Quick Links no longer have two title sections #33

Closed imcbride closed 6 years ago

imcbride commented 7 years ago

We decided that if editors want another section of Quick Links, they just add another Quick Links paragraph to the page, so there are no longer two title sections. I've removed the second one from the inner section. You may wish to update the surrounding markup, but it's not strictly necessary.

zebapy commented 6 years ago

This should actually be changed so callout-links__title is still present. Instead, the surrounding .section/.section__title should be removed.

https://github.com/middlebury/drupal8/blob/master/themes/custom/institute_theme/templates/paragraphs/paragraph--quick-links.html.twig

imcbride commented 6 years ago

Fixed in https://github.com/middlebury/drupal8/commit/4a0a043d1de6154c5b4224970f51b2ef2584b7f2. I've already removed the wrapping container div from the paragraph template, though that can be added back in the node template, as I'm doing for paragraphs on the homepage and top level pages.