Closed imcbride closed 5 years ago
RE: the limiter fields with “display:none”. Those shouldn’t appear. The widget code comes from EBSCO’s widget builder and I noticed that when you uncheck the unwanted features, it still leaves them in the code, so you end up with the “display:none” stuff crowding the code. On a similar note, I’m waiting for to see if they powers that be even want the “keyword, title, or author” radio buttons, or whether they want it to be as simple as the Summon one. For now, just the Keyword, Title, Author should show up.
Here's what I recommend for the checkbox markup https://github.com/middlebury/midd-frontend/blob/279d592b50eb9c4509826e45b563fd2db13ce38e/src/templates/partials/lib-search-tabs.twig#L26-L48
The Library is switching from Summon to Ebsco for a default search provider and has some new markup for this which I've adapted to our design here:
In Drupal, the script is added through a backend process so that it gets properly aggregated and cached, but I've added the raw tag at the top here for clarity. Here's a test site with it applied: http://saw.middlebury.edu/~imcbride/library/
As you can see, we need some styles for the radio buttons. In the markup above, there is also a hidden div with some limiting checkbox fields. These are set to not display and nothing in the JavaScript references them, so I have a question out to the librarians about whether we need to include them, but I've done so here just in case.